Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix adaptation bugs #668

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

chore: fix adaptation bugs #668

wants to merge 7 commits into from

Conversation

ArdtK
Copy link
Contributor

@ArdtK ArdtK commented Dec 20, 2024 •
edited
Loading

Issue addressed

Solves #664 and #665

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

  • Introduce AdaptationPartialResult class to pass/merge partial results
  • Introduce AdaptationResultEnum to standardize adaptation result column names better
  • Add/rename some columns

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@ArdtK ArdtK linked an issue Dec 20, 2024 that may be closed by this pull request
Adaptation: output gdf returns results on wrong links #664
Open
2 tasks
@ArdtK ArdtK marked this pull request as ready for review December 20, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptation: output gdf returns results on wrong links
1 participant
@ArdtK