-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement methods to create maps for wflow sbm + gw #56
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 75.42% 72.09% -3.33%
==========================================
Files 11 11
Lines 1542 1634 +92
==========================================
+ Hits 1163 1178 +15
- Misses 379 456 +77
Continue to review full report at Codecov.
|
Nice work @laurenebouaziz ! A few quick ideas/remarks
|
I've included the area_grid method in hydromt.raster module in a PR that I was working on, see Deltares/hydromt#74 |
thanks @DirkEilander , I will use this method for the surface area. Based on the discussion last Friday with Hélène, I will make the following changes:
planned: next week. |
For the 1D local inertial routing I have been using the |
The "river_bottom_elevation" map that I added for the groundwater module is based on a very simple relation relating river width to river depth (taken from the paper of Neal et al. 2012). Pretty sure that this is different than what you are working on now @DirkEilander. The RiverZ map is based on differences in the DEM from the high resolution elevation to the model resolution. This means that in areas with steep slopes, you get a very high depth (as in the Ardennes for the Meuse sometimes more than 100m) and in the flatter parts you get very low river depths, which might not be very realistic. The simple formulation of river_bottom_elevation leads to a very different pattern, with depths of about 6m at Borgharen and about 1m in the tributaries. See the two maps below which show (dem - riverZ) and (dem - river_bottom_elevation) (note the differences in scale!) |
My approach is similar to what @laurenebouaziz has implemented but relating river depth to bank full discharge following Andreadis et al (2013). @verseve I was under the assumption that for the 1D-2D approach we need a river bed elevation and river depth / bankfull elevation. The first will be the riverZ elevation minus the river depth; the second is the riverZ elevation, not the wflow_dem as it contains the the cell average elevation which in steep areas can be quite different from the river bed elevation as pointed out by Laurene. If we start schematizing the floodplains in 1D we could include the gradient of the floodplains as well to differentiate between rivers in flat terrain and steep valleys. |
Yes, correct @DirkEilander , indeed for the 1D-2D approach we need a river bed elevation and river depth/ bankfull elevation. For the 1D approach (water stays in the river) I use the riverZ elevation now for testing purposes. |
added maps for:
to do: