clean grid variables when recreating a grid #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
When re-running the setup_grid (or setup_grid_from_region) functions after you added a gridded varaible, dep or msk for example, the RegularGrid class was updated correctly, but the SfincsModel.grid seemed to stick on the first grid and therefore the model didn't update correctly.
Not sure when this was introduced, but espeically in a GUI, refining the grid after adding variables happens often, so this is a serious bug ...
Explanation
setup_grid is always called when creating a new grid, so forcing the SfincsModel.grid to start blanco should solve the problem
Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.