Parse forcing precision #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otherwise any pressure input is ignored....
There was a problem hiding this comment.
Looks good to me! Note that it does not completely solve #197. We should also respond in the issue what we will do with the idea by to store the forcing format as an attribute of SfincsModel. I think this has low priority for us, but we can welcome a contribution on this from the issue owner.
DirkEilander
approved these changes
Aug 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #197
Explanation
By default still two decimals are used, but you can overwrite the fmt in SfincsModel.write_forcing.
Another option is to provide fmt="auto", then the format is derived from the forcings.
Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.