Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sfincs.py #124

Closed
wants to merge 1 commit into from
Closed

Update sfincs.py #124

wants to merge 1 commit into from

Conversation

Leynse
Copy link
Collaborator

@Leynse Leynse commented Sep 8, 2023

  • Xarray.rename input type seems to have changed
  • Only relevant for precip_2D and press_2D? (or more?)

- Xarray.rename input type seems to have changed
- Only relevant for precip_2D and press_2D? (or more?)
@DirkEilander
Copy link
Contributor

As discussed with @Leynse via chat, I think this issue is caused by the fact that the method is called with a xarray.Dataset instead of xarray.DataArray object for the precip and press arguments. These arguments were not clipped or filtered in the released HydroMT DataCatalog.get_rasterdataset functionality, but this has been solved in Deltares/hydromt#481. Now when given a dataset and then parsing it with e.g. DataCatalog.get_rasterdataset(variables=['precip'] it should only return the precip variable as DataArray, Hence I think this fix is not necessary.

@roeldegoede roeldegoede deleted the Leynse-patch-1 branch November 10, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants