Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#289 add damage unit #292

Merged
merged 11 commits into from
Apr 24, 2024
Merged

#289 add damage unit #292

merged 11 commits into from
Apr 24, 2024

Conversation

Santonia27
Copy link
Collaborator

add the currency to the settings.toml file and the exposure buildings model.

@panosatha
Copy link
Collaborator

It is nice that the damage unit is now writtern in the settings toml. Right now it seems that in order to read that you need to access FiatModel.config["exposure"]["csv"]["damage_unit"].

Wouldn't it make more sense for this to be an attribute of the FiatModel.exposure.damage_unit?

@Santonia27
Copy link
Collaborator Author

Yes that makes sense, do you mean like this?

image

I already committed the changes

@panosatha
Copy link
Collaborator

I meant more from the object and class attributes and how to access them when you read in the model with HydoMT-FIAT.

So, when I use:
fiat_model = FiatModel(root=fiat_path, mode="r+")

fiat_model is an object with a couple of attributes, e.g.:
image

So, I think it would be nice if "damage_unit" was an attribute there the same way "unit" is.

@Santonia27
Copy link
Collaborator Author

okay I added it as a variable to the exposure model

@panosatha panosatha merged commit 0c96ce0 into main Apr 24, 2024
1 check passed
@panosatha panosatha deleted the #289_add_damage_unit branch June 5, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants