add user warning when data crs conflicts with provided crs #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once again the step seems to fail due to some segfault I can't pin down but the tests do pass, so justas with theprevious, I'm just opening this one up for review anyway. |
|
Fixed in #481 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #462
Explanation
Does what it says on the tin. Wasn't able to add a test for the rasterdataset adapter that the warning is actually emitted because the kwargs don't get passed to the underlying funtions always, but I figured it was good to keep the warning there anyway just to be sure. The logic is the same as with the other adapters so it should be fine.
Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.