-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple csv segmented by var #489
Conversation
Makrking this as ready for review as the failure in the CI seems to happen after all the tests have passed. Possibly it's somehthing with the report generation. I'm investigating that seperately. |
For posterities sake, the CIs crach with the following message:
|
note to self: add to doc index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Issue addressed
#453
Explanation
So I don't think this PR addresses an issue exactly, but it was something that I setup in #486 and wanted to finish anyway. I think it makes significant progress if not outright solve #453 (not totally sure which of the two it is, I'll leave that for the reviewer decide, or we can discuss it during stadnup/refinement) and makes some additional progress towards #372.
This simply adds the possibility for
open_mfcsv
to not only parse files per id, but also files per variables containing all ids (though not at the same time). The resulting dataset is the same as when the same data was segmented by id. I think it's a nice flexibility to have.Checklist
main
Additional Notes (optional)
Add any additional notes or information that may be helpful.