-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version switch to docs #457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! Thanks @savente93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just one small addition, could you add a step to the release guide docs to make sure the switcher.json file gets updated on every release?
Can't we add this file to the root of the gh-pages branch directly? The url would than be "https://github.com/Deltares/hydromt/blob/gh-pages/switcher.json" and that should work for all versions right? |
That's actually a really good idea. Although it won't make it appear on the older versions, that is a config setting, so we'd have to go back to all the previous versions of the docs and add it to the config to solve this issue |
Issue addressed
Fixes #188
Explanation
simplay followed the link and followed the docs. Works just fine. The only downside is that the older versions of the docs don't have this added so once you switch, the menu for it disapears. Can go back and retroactively add this back to the older versions if necessary, but this could give issues with reproducability (e.g. not sure if this plugin is compatable with older doc versions.)
Checklist
main
Additional Notes (optional)
Currently the url of the version switcher points to a file that will be deleted when the branch is deleted. Once this is approved, I'll switch it over to where the file will live after merging. This will temporary break the docs between update and merging as the file needs to be found for the docs to be generated, but should this should be fixed as soon as the merge is complete, so it should be fine.