-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configure using TOML files #444
Conversation
Since Toml doesn't support any type of |
Thanks for this this PR @savente93! I noticed that the PR does more than just fixing #376, which requests toml support for model configuration files in the Model.read_config / write_config methods. This PR also adds toml support for HydroMT data catalog and configuration files. We should have a discussion with the team/users if this is indeed wanted. My initial thoughts: What do you think @hboisgon @alimeshgi @B-Dalmijn @Tjalling-dejong ? |
right, that's true. The part of the catalog being in TOML was from when I still misunderstood the objective. I still think it's a nice feature though, especially given the recommendations from DSC. Do note that I'm not suggesting we move everything to toml, this is simply support for it, so it would enable users to have all their config files in toml if they'd like. But as you say, let's indeed discuss in the next standup. |
I agree that using different file formats can potentially confuse users. Consistency in file formats often helps maintain simplicity and ease of use. Yes, let's discuss it in the next stand-up. |
Converted to draft until we can reach a consensus on #452 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue addressed
Fixes #376
Explanation
Very simple implementation, because almost everything is done using dictionaries all that was needed was just swap the yaml functionality for the toml. (doc updates to come)
Checklist
main
Additional Notes (optional)
Add any additional notes or information that may be helpful.