Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progressive web app configuration #992

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hvangeffen
Copy link
Collaborator

@hvangeffen hvangeffen commented Sep 20, 2024

Description

Defaults to standard web oc deltares icon and description.
When run outside of the CI in build mode will also download logo and description / title from the web oc config endpoint of the fews webservices set in the env variables.
Maybe for deploy we want to have a specific flag (env variable) to do set this, so that lemon / gray coast and such have PWA.

Example generated manifest

{
  "name": "ETheKwini Early Warning System",
  "short_name": "WebOC",
  "start_url": "/",
  "display": "standalone",
  "background_color": "#ffffff",
  "lang": "en",
  "scope": "/",
  "description": "ETheKwini Early Warning System",
  "theme_color": "#080c80",
  "icons": [
    { "src": "pwa-64x64.png", "sizes": "64x64", "type": "image/png" },
    { "src": "pwa-192x192.png", "sizes": "192x192", "type": "image/png" },
    { "src": "pwa-512x512.png", "sizes": "512x512", "type": "image/png" },
    {
      "src": "maskable-icon-512x512.png",
      "sizes": "512x512",
      "type": "image/png",
      "purpose": "maskable"
    }
  ]
}

This can be updated by the person deploying the application. As well as updating the images in the dist root:
image

Screenshots

Default config

image
image
image

Config gotten remotely

image
image
image

Link to documentation (if applicable)

Add link to public Github pages (only documentation about configuration)

Checklist

  • Make the title short and concise
  • Select the correct label to include it in the release notes:
    • rel: new feature
    • rel: improvement
    • rel: fixes
    • rel: ignore
      Select to rel: ignore if this pull request fixes a New Feature or Improvement in the coming release. Update related Pull Request.
  • Update documentation.
  • Update tests.

@hvangeffen hvangeffen self-assigned this Sep 20, 2024
@hvangeffen hvangeffen linked an issue Sep 20, 2024 that may be closed by this pull request
@hvangeffen hvangeffen force-pushed the 991-progressive-web-app-configuration branch 2 times, most recently from 7242939 to a7c8fb3 Compare September 23, 2024 08:52
@hvangeffen hvangeffen marked this pull request as ready for review September 23, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progressive Web App configuration
2 participants