Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix width of date table column #1046

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Fix width of date table column #1046

merged 4 commits into from
Nov 14, 2024

Conversation

wkramer
Copy link
Collaborator

@wkramer wkramer commented Nov 7, 2024 •
edited
Loading

Description

The date column in a time series table has a fixed width, giving more space to the value columns.

Screenshots (if applicable)

image

hvangeffen
hvangeffen reviewed Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@hvangeffen hvangeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only difference I seem to notice is the Date header being aligned to the top. Removing the added 24ch locally doesn't seem to change the width of the column.

Old

Screenshot 2024-11-11 at 09-48-53 SMART Polder System

This PR

Screenshot 2024-11-11 at 09-49-06 SMART Polder System

@amarkensteijn amarkensteijn merged commit c44343c into main Nov 14, 2024
8 checks passed
@amarkensteijn amarkensteijn deleted the 1018-width-of-date-table-column branch November 14, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvangeffen hvangeffen hvangeffen left review comments

Assignees
No one assigned
Labels
rel: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkramer @hvangeffen @amarkensteijn