Implement report feature suggestions #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkramer
reviewed
Sep 27, 2024
vite.config.ts
Outdated
| @@ -74,7 +74,7 @@ export default defineConfig(({ mode }) => { | |||
| }), | |||
| ], | |||
| optimizeDeps: { | |||
| exclude: ['@deltares/fews-ssd-webcomponent'], | |||
| exclude: ['@deltares/fews-ssd-webcomponent', 'vuetify'], | |||
There was a problem hiding this comment.
Put in its own pull request
wkramer
force-pushed
the
1008-implement-report-suggestions
branch
from
7ca7c74
to
3b61a4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downloaded file name example:
2024-09-26T10_45_00Z-ReportRainfallReturnPeriodTableForecast.htmAlso excludes
vuetifyfrom optimizedDeps since with the treeshake change it has to reload the vite server every time a new vuetify component is used within a newly loaded async component.Screenshots
Checklist
rel: new featurerel: improvementrel: fixesrel: ignoreSelect to
rel: ignoreif this pull request fixes a New Feature or Improvement in the coming release. Update related Pull Request.