-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rws network #67
Rws network #67
Conversation
…into RWS-network
…into RWS-network
…into RWS-network
In Ribasim 2024.2.0 the node IDs are only unique to the node type, so that simplifies the merging quite a bit. |
@visr; actually I think it will make merging (reindexing) a little bit more complex. I would like to have all nodes a unique id so I can create a networkx object (using Node and Edge) and route trought the network. But I can concat node_id and type and do the same for edge, so that's OK. |
This should work:
Downside is that it requires a model instance. But the results doesn't depend on the model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Glad to see this progress, a lot of work has been done. Looking at the amount of code I feel like the upcoming changes in Ribasim would've been useful. Updating to the new version might be a bit painful, also since there are not many tests here.
Co-authored-by: Martijn Visser <[email protected]>
Co-authored-by: Martijn Visser <[email protected]>
Co-authored-by: Martijn Visser <[email protected]>
Co-authored-by: Martijn Visser <[email protected]>
Co-authored-by: Martijn Visser <[email protected]>
Co-authored-by: Martijn Visser <[email protected]>
Co-authored-by: Martijn Visser <[email protected]>
…into RWS-network
All code to create the hws and lhm 2024.2.X model-versions.
@visr, curious to your thoughts on how we merge models. I resetting a model index and concatting multiple models is defined here
https://github.com/Deltares/Ribasim-NL/blob/RWS-network/src/ribasim_nl/ribasim_nl/reset_index.py
https://github.com/Deltares/Ribasim-NL/blob/RWS-network/src/ribasim_nl/ribasim_nl/concat.py
For that I need to know tables with node_id columns from ribasim. Would be great if I could read that from the module directly instead of having my own global variable:
Ribasim-NL/src/ribasim_nl/ribasim_nl/model.py
Lines 11 to 22 in 1262ebd