Run AGV shortest_path and crossings_to_ribasim #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shortest path script is modified for AGV to be able to run from the cloud.
I modified
crossings_to_ribasim.pya bit so I could run it outside the HKV network. I removed HKV-specific code regarding the P and Z drives for writing results, and only retained the cloud saving. I also removed the symbology writing, I'm not sure what it was like, but if that is really needed it could be brought back if that data is shared. Ribasim Python now writes the default symbology in the GeoPackage. These changes will probably affect @rbruijnshkv though, so good to have a look at that.I also addressed some warnings and fixed the fact that the Node table was written without a CRS. There are more warnings though. It's best to not filter them out, because mistakes are easily made if they are not addressed.
This does generate a valid AGV model / network (not yet parametrized, only with default values), that does run. I didn't yet compare the outcome to the uploaded models. It is here if you want to look: _repro.zip.