Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate shortest path code #176

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Deduplicate shortest path code #176

merged 1 commit into from
Oct 22, 2024

Conversation

visr
Copy link
Member

@visr visr commented Oct 21, 2024

The code was identical except for comments and print statements. So now we move it all into a single function that is part of the package, so the individual scripts are just a few lines.

Only AGV was an outlier since it had a lot of code after the shared code. Perhaps @rbruijnshkv can comment on if that is needed or not. Another difference I noticed is this, AGV has this set to 5:

        distance_interval = 50  # The distance interval you want to segment the lines at

This only deduplicates, I didn't want to start modifying the code at the same time. So I cannot run it since it relies on local paths that I don't have.

@visr visr requested a review from rbruijnshkv October 21, 2024 16:18
Copy link
Collaborator

@rbruijnshkv rbruijnshkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through it quickly, it seems okay! Changes in this part of the code are by the way not expected to break the code later on, but at most the visualization (which is not necessarily inferior).

@visr visr merged commit 68c5dbc into main Oct 22, 2024
4 checks passed
@visr visr deleted the shorter-path branch October 22, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants