Fix dommel network #129
Merged
Fix dommel network #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
reviewed
Aug 19, 2024
visr
added a commit
that referenced
this pull request
Aug 19, 2024
Fixes #122. At this point we'll work with the already uploaded results of ribasim_lumping and patch those up for use with the current Ribasim version, like for instance done in #129. That means for now we don't need to update this code to run. I don't delete the code because we probably want to use it later on and may need to look at the implementation. This does mean we cannot `import ribasim_lumping` within the pixi environment.
Co-authored-by: Martijn Visser <[email protected]>
…sim-NL into fix_dommel_network
visr
approved these changes
Aug 20, 2024
visr
added a commit
that referenced
this pull request
Aug 22, 2024
Fixes #122. At this point we'll work with the already uploaded results of ribasim_lumping and patch those up for use with the current Ribasim version, like for instance done in #129. That means for now we don't need to update this code to run. I don't delete the code because we probably want to use it later on and may need to look at the implementation. This does mean we cannot `import ribasim_lumping` within the pixi environment. Also updates dependencies with `pixi update`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains all work for #102, including:
reverse_edge: reverse an edge and it'sfromandtopropertiesremove_noderemove a node, possibility to remove connected_edges as wellremove_edge: remove an edge, possibility to remove disconnected_nodes as wellAll results in a topologically correct network that passes the RIBASIM network validator and simulation. Note, all parameters are implausible still:
