Fix ruff errors on main #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These notebooks were used to post process the delivered data of the waterschappen. They have been modified severely, so remove them all and add new ones.
In this period, we focused on coupling the AGV model to the national network while ensuring the AGV model implements functionalities for water supply and drainage situations. Initially, we achieved this using a single notebook. Next, we will scale up and implement it across other waterschappen. In the near future, we plan to streamline this by calling a single Python file instead of ten similar notebooks, which should reduce maintenance time. Hence, the other other notebooks have been deleted.
Fixed ruff simultaneously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a part of #120. The goal for this PR is to resolve all 53 open ruff errors on main, without adding exceptions. Currently the commits in this PR bring it down to 29. The remaining errors are all of the form
F821 Undefined name, where the name is:For various files. Will look with @rbruijnshkv to resolve the rest.