Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/unst 8528 sources sinks converter #721

Open
wants to merge 55 commits into
base: feature/unst-8490-621_extforce_converter-boundary-condition
Choose a base branch
from
Open

Feature/unst 8528 sources sinks converter #721

wants to merge 55 commits into from

Conversation

MAfarrag
Copy link

No description provided.

MAfarrag added 19 commits December 5, 2024 11:56
@MAfarrag
add a pull request template
5211d96
@MAfarrag
correct test folder name from extold to ext
1726a38
@MAfarrag
optimize the ext.models.Boundary.forcing property to have one retur…
d0b183e 
…n statement at the end of the property.
@MAfarrag
test the ExtOldParametersQuantity class
d68e75d
@MAfarrag
correct assert statement is test_ext_old_initial_condition_quantity…
5db0ceb 
… test
@MAfarrag
move the TestModels.TestLateral from thr test_ext.py to a separate te…
99d47d4 
…st file test_laterals.py
@MAfarrag
correct the test file description
8e5314f
@MAfarrag
reformat the test_boundary.py file
f4246d2
@MAfarrag
clean the test file from unused imported functions
b3c92b1
@MAfarrag
remove unused class ext.models.InitialConditions
eef3351
@MAfarrag
add reference to the initial condition documentation in the `InitialF…
de14bf0 
…ield` class
@MAfarrag
add ParametersConverter class and test
d0ee415
@MAfarrag
merge the BaseConverter class to the converters module
656b112
@MAfarrag
test MeteoConverter
1e3552a
@MAfarrag
merge converter_factory module to the converters module
31a0a99
@MAfarrag
merge the enum_converters module to utils
7387036
@MAfarrag
merge the __contains__ to the ConverterFactory class
c4e5892
@MAfarrag
abstract duplicate lines in the parameter and initial condition conve…
540f4e4 
…rters
@MAfarrag
merge changes from base branch
25bd8c5
@MAfarrag MAfarrag changed the base branch from main to feature/unst-8490-621_extforce_converter-boundary-condition December 12, 2024 10:14
@MAfarrag
add ExtOldSourcesSinks class for the source and sinks quantities
56930f9
@MAfarrag
test ExtOldSourcesSinks class for the source and sinks quantities
5092c75
@MAfarrag
Merge branch 'feature/unst-8490-621_extforce_converter-boundary-condi…
7556303 
…tion' into feature/unst-8528-sources-sinks-converter
@MAfarrag
fix using mutables as default value, and use absolute imports
75988fb
@MAfarrag
abstract the conversion of the interpolation related info in a separa…
726f01b 
…te function
@MAfarrag
add docstring and test for the convert_interpolation_data method
8779cb7
@MAfarrag
add reference to documentation for the tim model
6d6dad0
@MAfarrag
remove unused fields in the TimParser
f17b36c
@MAfarrag
move the convert_interpolation_data from the converters.py to the u…
55ad838 
…tils.py
@MAfarrag
move the convert_initial_cond_param_dict from the converters.py to …
ffa8a95 
…the utils.py
MAfarrag and others added 26 commits December 18, 2024 14:36
@MAfarrag
add docs for the UnknownKeywordErrorManager
51e5fdb
@MAfarrag
refactor the UnknownKeywordErrorManager
b811686
@MAfarrag
use absolute imports
fe27aee
@MAfarrag
add a class method _exclude_from_validation to enable bypassing the…
297d919 
… `raise_error_for_unknown_keywords`
@MAfarrag
create a SourceSink class and tests
16fa483
@MAfarrag
refactor the TestSourceSink
8394df1
@MAfarrag
change the type of discharge in the SourceSink class to float or li…
11d654c 
…st[float]
@MAfarrag
add SourceSinkConverter and tests
6be8c44
@MAfarrag
test discharge constant value in the SourceSink
304cd39
@MAfarrag
add utility function for locate the temperature and salinity in the q…
33a467e 
…uantities list
@MAfarrag
add missing test files for the `test_converters.py::TestSourceSinkCon…
cf3a3a4 
…verter.test_default`
@MAfarrag
the find_temperature_salinity_in_quantities no returns a dictionary…
4cdcdd4 
… with `temperaturedelta` and `salinitydelta` not temperature and salinity
@MAfarrag
add default test case for the SourceSinkConverter
33e6cd2
@MAfarrag
reformat the polyfile tests
3768ecb
@MAfarrag
add testcase for polyfile with 2*3
3e8ed26
@MAfarrag
add testcase for the polyfile with 2*5 dimensions
a6a99c9
@MAfarrag
add SourceSinkConverter.get_z_sources_sinks method and tests
c1a70ae
@MAfarrag
add initialsedfrac quantity name to the SourcesSink model
b50b823
@MAfarrag
test SourceSinkConverter with a 5 column polyline file
3e477e1
@MAfarrag
test SourceSinkConverter.parse_tim_model with quantities_list and t…
4f8aeb5 
…im file mismatch
@MAfarrag
test SourceSinkConverter.parse_tim_model with default case
5934485
@MAfarrag
move the SourceSinkConverter tests to a separate test file
8847cc0
@MAfarrag
add missing test files
0396cb4
@MAfarrag
add all cases of the temperature/salinity in the external forcing fil…
3575aba 
…e wrt the tim file
@MAfarrag
add no temperature no salinity to the SourceSink converter
966f8d0
@MAfarrag
make the discharge attribute not optional
6b530a5
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MAfarrag