Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/move more mdu keywords #654

Merged
merged 38 commits into from
Jul 5, 2024
Merged

Add/move more mdu keywords #654

merged 38 commits into from
Jul 5, 2024

Conversation

tim-vd-aardweg
Copy link
Contributor

refs: #648

tim-vd-aardweg and others added 30 commits July 1, 2024 09:01
@tim-vd-aardweg
648: Added testcase that should pass but currently fails.
4edf684
@tim-vd-aardweg
648: Fixed capitalization.
71c9bb1
@tim-vd-aardweg
648: Removed research keyword that was already implemented as a regul…
7f25d9a 
…ar keyword.
@tim-vd-aardweg
648: Moved lateralfixedweirumin from research to regular.
a3f551f
@tim-vd-aardweg
648: Added wrimap_calibration keyword to [output]
eccdba7
@tim-vd-aardweg
648: Added optional guiversion to [general].
079c8bc
@tim-vd-aardweg
648: Add wrimap_salinity to [output].
3b92b03
@tim-vd-aardweg
648: Added wrimap_temperature to [output].
2a066d9
@tim-vd-aardweg
648: Updated wrimap_input_dt to Wrimap_every_dt.
301a76e
@tim-vd-aardweg
648: Moved jasfer3d from research to regular.
ed3796b
@tim-vd-aardweg
648: Move writepart_domain from research to regular.
e71fcb7
@tim-vd-aardweg
648: Make jasfer3d not optional.
f3df0eb
@tim-vd-aardweg
648: Fixed name/alias of lateral_fixedweir_umin.
869477d
@tim-vd-aardweg
648: Moved velocitydirectionclassesinterval from research to regular.
be8a024
@tim-vd-aardweg
648: Added noderivedtypes to ResearchNumerics.
70e7549
@tim-vd-aardweg
648: Run black.
772da44
@tim-vd-aardweg
648: Updated description of usevolumetables.
6db4154
@tim-vd-aardweg
648: Removed some obsolete keywords from test files.
6b00cff
@tim-vd-aardweg
648: Update description
be38f60
@tim-vd-aardweg
648: Added jadelvappos to ResearchNumerics.
4db105a
@tim-vd-aardweg
648: Removed some more obsolete keywords from test files.
356ad26
@tim-vd-aardweg
648: Update wrimap_input_dt to wrimap_every_dt in test file.
1a478f8
@tim-vd-aardweg
648: Added jarhoxu to ResearchNumerics.
b750d8f
@tim-vd-aardweg
648: Change jaupwindsrc from int to bool.
28595b7
@tim-vd-aardweg
648: Update description of eddyviscositybedfacmax.
e3a24ba
@tim-vd-aardweg
648: Changed zlayercenterbedvel from int to bool.
4b03b9b
@tim-vd-aardweg
648: Update description of horadvtypzlayer.
85c6000
@tim-vd-aardweg
648: Update description of drop3d.
39993ff
@tim-vd-aardweg
648: Update description of selfattractionloading.
4591970
@tim-vd-aardweg
648: Removed obsolete keyword umodlin.
c2fa29d
@tim-vd-aardweg tim-vd-aardweg linked an issue Jul 4, 2024 that may be closed by this pull request
Add missing mdu keywords (phase 2) #648
Closed
3 tasks
MRVermeulenDeltares
MRVermeulenDeltares approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@MRVermeulenDeltares MRVermeulenDeltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved when the problems with the tests have been resolved.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tim-vd-aardweg tim-vd-aardweg merged commit 5963745 into main Jul 5, 2024
11 checks passed
@tim-vd-aardweg tim-vd-aardweg deleted the feature/648_Add-more-missing-keywords branch July 5, 2024 11:12
@veenstrajelmer veenstrajelmer mentioned this pull request Jul 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRVermeulenDeltares MRVermeulenDeltares MRVermeulenDeltares approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing mdu keywords (phase 2)
2 participants
@tim-vd-aardweg @MRVermeulenDeltares