Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the loadouts #2711

Merged
merged 18 commits into from
Jan 12, 2025
Merged

Conversation

Radezolid
Copy link
Contributor

About the PR

New loadouts:

  • Warden DeltaV loadout to untouch the upstream one as it's just filled with DeltaV comments.
  • Head of Security loadout, same reason as above.
  • Detective loadout, same reason.

Changes:

  • Cleaned two repeated loadouts groups.
  • Moved DeltaV loadout groups to the DeltaV file.
  • Modified comments.

The role_loadouts.yml comments are a mess, and moving lines would only cause more conflicts on upstream merge, so i just let them be.

Why / Balance

DeltaV loadouts in upstream files is bad and comments were ugly.

Technical details

Changed role_loadouts.yml to reflect the three new sec DeltaV loadouts.

Media

N/A

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

None.

Changelog

N/A

@Radezolid Radezolid requested a review from a team as a code owner January 12, 2025 11:38
@github-actions github-actions bot added size/L 256-1023 lines S: Needs Review Changes: YML Changes any yml files and removed S: Needs Review labels Jan 12, 2025
@deltanedas deltanedas merged commit fbae628 into DeltaV-Station:master Jan 12, 2025
14 checks passed
@Radezolid Radezolid deleted the Clean-loadouts branch January 12, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants