Acidifying Sec Crates & Emergency Lasers

[rosieposieeee]

About the PR

Ports these three PRs:
Make sure you read them before you comment!
impstation/imp-station-14#623
impstation/imp-station-14#628
impstation/imp-station-14#656

Anyway, as a summary, this PR ACTUALLY locks these crates in a meaningful way, requiring either armory access or an emag, so cargo doesn't stealth self-antag buy an entire armory's worth of guns and drills them open the moment someone on station spills milk. The acidifier failsafe can be disabled with a screwdriver whilst the crate is unlocked

To compensate for this change, an emergency laser crate is added with VERY obvious laser guns, in a crate the LO or any other member of command can open.

May add emergency WT550 or drozd if necessary, also if deltanedas could tell me how to properly set up rng generation in the code I can make it have a small % chance to still drop the items when broken.

Media

sec_crate.mp4

NOTE: I hereby release the miniscule changes made in this PR under MIT license that weren't part of the original port but the rest is still AGPL so that's probably useful to nobody.

Requirements

• I have tested all added content and changes.
• I have added media to this PR or it does not require an ingame showcase.

Changelog
🆑 rosieposieeee, TGRCdev, kipdotnet

• tweak: High security crates now acidify when destroyed whilst locked.
• add: Added Emergency Laser Rifles, for when the station is in truly dire straits.

[github-actions]

RSI Diff Bot; head commit 6ffad1e merging into 60c5291
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Impstation/Objects/Weapons/Guns/Battery/emergency_laser_gun.rsi

State	Old	New	Status
base			Added
equipped-BACKPACK			Added
equipped-SUITSTORAGE			Added
icon			Added
inhand-left			Added
inhand-right			Added
mag-unshaded-1			Added
mag-unshaded-2			Added
mag-unshaded-3			Added
mag-unshaded-4			Added
wielded-inhand-left			Added
wielded-inhand-right			Added

Edit: diff updated after 6ffad1e

[deltanedas]

rng is just like if (_random.Prob(0.05f)) return; with IRobustRandom added as dependency

[rosieposieeee]

random_failure.mp4

fails 25% of the time

[Proxysseia]

Heavily against this PR.
Adds an extra tax to antags ("just by emag") when Cargo Techs just got their TC reduced in order to account for them not needing to buy an emag. Crates ordered by random non antag cargo techs and distributed to the crew are already multiple IC and OOC crimes.
Hampers RP opportunities by not letting crew re arm after security/captain died in an armory attack. Nukies attack armory now and win by default, option to rebound is removed entirely because the crates acidify.
This PR is another one in the vein that any action against nukies that isnt running away is somehow bad RP, and that falling back to a secondary position in order to aquire arms, armor and medicine is somehow throwing away your life.

Players who are shitters and self antag by just buying guns for no reason are obviously breaking server rules and will be punished accordingly. This PR is an ingame bandaid fix that hurts both antags and non antags ability to tell a story, for something that is an administration issue.

[rosieposieeee]

i think this PR would justify cargo techs getting their TC back - and i prefer rules be backed by mechanics, for rounds when no admins are online, especially on apo. a ballistic emergency crate would solve the problem if someone wants to make the sprites for that, and worst case scenario crew can just buy LOTS of crates and roll the failure chance.

[Lyndomen]

i think this PR would justify cargo techs getting their TC back - and i prefer rules be backed by mechanics, for rounds when no admins are online, especially on apo. a ballistic emergency crate would solve the problem if someone wants to make the sprites for that, and worst case scenario crew can just buy LOTS of crates and roll the failure chance.

Agreed, feel free to add 2 TC back to their allotment

[rosieposieeee]

gave em 2 TC back :)

[Lyndomen]

gave em 2 TC back :)

Sowwy can you take one extra away then approved. Total TC handicap 2

[rosieposieeee]

okies

[HTMLSystem]

Hey, so, if I'm looking at the code right the AntiTamper tag is added to CrateBaseSecure. All the departmental secure crates parent off of CrateBaseSecure. Would this not effect all secure crates like AME fuel?
If it will, that will be awful and basically stop any low pop rounds from happening if there happens to be no engineers. That or encourage people to break in head offices, which isn't nice.
Edit: An easy fix for this would be to at the AntiTamper tag to CrateSecGear.

[rosieposieeee]

Hey, so, if I'm looking at the code right the AntiTamper tag is added to CrateBaseSecure. All the departmental secure crates parent off of CrateBaseSecure. Would this not effect all secure crates like AME fuel? If it will, that will be awful and basically stop any low pop rounds from happening if there happens to be no engineers. That or encourage people to break in head offices, which isn't nice. Edit: An easy fix for this would be to at the AntiTamper tag to CrateSecGear.

good catch!!!! fixing now

[rosieposieeee]

oh maintaiiiiiiners (jingling car keys)

[Radezolid]

Responding to the key jingling

[rosieposieeee]

@Radezolid jingles keys again

[Radezolid]

Two things that escaped my previous review

[rosieposieeee]

@Radezolid jinglejinglejingle

[Radezolid]

Looks fine YML-wise to me, I got no idea if the code needs something done.

[rosieposieeee]

@deltanedas jingles keys