Adds two songs to different areas in the game entirely. #2514
Conversation
github-actions
bot
added
size/XS
|
In the changelog, you should specify that Garbage Land is added to the jukebox in particular, as opposed to the lobby or something. |
|
Fuck, Colin, you're so fucking right. |
|
@Lyndomen meow |
| @@ -41,6 +41,11 @@ | |||
| copyright: "every light blinking at once by Sunbeamstress, converted to mono" | |||
| source: "https://soundcloud.com/sunbeamstress/every-light-is-blinking-at-once" | |||
|
|
|||
| - files: ["Red_Vox_-_Garbage Land_MONO.ogg"] | |||
| license: "Custom" | |||
There was a problem hiding this comment.
get a concrete license from them like CC-BY-NC-SA-3.0 (attribution, non commercial, share alike) which is similar to the loose terms given
There was a problem hiding this comment.
Garbage Land
Space Asshole
DOS=HIGH, UMB
On the bandcamp pages for this song, Space Asshole, and DOS=HIGH, UMB, they're all already under an "all rights reserved" license, which is a concrete license, and all of them are put under Custom because they are all used in the game with permission from the artist.
I'll change the file to clarify such if needed for both, though I did get Red Vox to agree to using it non commercially with credit here, and I had to edit the song for the sake of it sounding decent in the jukebox.
That being said, please keep in mind that these two songs are All Rights Reserved and they NEED to be licensed under "Custom" because to my knowledge, attributions YAML shits itself if you aren't using a very specific CC license (hell, another good example is if you're using public domain CC 0, like Leisurely Voice, it won't work.)
… the license was All Rights Reserved, which attributions yaml won't support AAAAAAAAAAAAaa
|
Direction is reviewing, get back to you in about 24 hours |
|
Heya, we listened to both of these and think they're both pretty cool. Our consensus is that Atom Bomb wouldn't quite fit as a nuke countdown song due to it being highly lyrical (though we would be willing to consider an instrumental version if you'd like to PR that). We'd be happy to have both in the jukebox though. Thanks! |
About the PR
Adds two songs from the band Red Vox, Garbage Land and Atom Bomb respectively. Red Vox fans, rejoice.
Why / Balance
I really like this band and I decided to email their frontman (Vinny) about if I was allowed to use it, and he said "Sure, have fun!"
Garbage Land I can sort of see fitting in the game if it wasn't centered on New York, Atom Bomb seemed like a good candidate for a "let's blow up the station" song for the title and just the concept of the song, really.
This would not affect game balance in the slightest other than giving us banger tunes.
Technical details
Adds another section to attributions.yml for the jukebox to credit a new track, "Garbage Land."
Also adds a new DeltaV/StationEvents folder in the audio section, if we ever want to add more custom nuke-explosion songs. Only files in there are Atom Bomb and the new attributions.yml.
Edits one upstream file (NukeMusic.yml) to add the new song, "Atom Bomb."
Requirements
Breaking changes
Makes the upstream merge a little more arduous if there's changes to nuke songs, and will cause merge conflicts. Sorry Deltanedas, let me know if I have to fix it.
Changelog
🆑