Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy! #2487

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Clippy! #2487

wants to merge 9 commits into from

Conversation

Unkn0wnGh0st333
Copy link
Contributor

@Unkn0wnGh0st333 Unkn0wnGh0st333 commented Dec 20, 2024 •
edited
Loading

About the PR

Ports Clippy from Frontier to be the courier's new beloved pet!

Why / Balance

This is necessary

Technical details

  • Adds a very small C# file to let cats wear hats
  • Adds new pet type from frontier
  • Adds Clippy
  • Adds Clippys Bag (similar to Ian Bag) that the courier can unlock
  • Adds Clippy
  • Adds the ability for cats to wear hats
    • Only effects Clippy, Runtime, Bingus, and Exception (Floppa can't wear hats)

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an in-game showcase.

Changes

  • New spawn for mapping to add Clippy

Changelog
🆑

  • add: Clippy from Frontier has been transferred to DeltaV stations! Couriers now have a new pet and bag to unlock!

@github-actions github-actions bot added size/L 256-1023 lines Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

RSI Diff Bot; head commit 2739b7d merging into c34c044
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Nyanotrasen/Clothing/Head/Hats/mailman.rsi

State Old New Status
equipped-HELMET-cat Added

Resources/Textures/_NF/Clothing/Back/Backpacks/clippy.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Tips/clippy.rsi

State Old New Status
down Added
left Added
right Added

Edit: diff updated after 2739b7d

@Unkn0wnGh0st333 Unkn0wnGh0st333 marked this pull request as ready for review December 22, 2024 17:37
@Unkn0wnGh0st333 Unkn0wnGh0st333 requested review from a team as code owners December 22, 2024 17:37
Lyndomen
Lyndomen requested changes Dec 22, 2024
View reviewed changes
Resources/Prototypes/_NF/Entities/Mobs/NPCs/pets.yml Outdated Show resolved Hide resolved
Resources/Textures/Nyanotrasen/Clothing/Head/Hats/mailman.rsi/meta.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a maints thing for fish guy, but could move this to delta namespace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehh idk maybe. tbh I don't see why the OG nyanostuff still exist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly this hat should be moved under DeltaV at that point

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes dont add new things to nyano namespaces its purely legacy

Resources/Prototypes/_NF/Roles/Jobs/Fun/misc_startinggear.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Changes: Audio Changes any audio files label Dec 22, 2024
@Unkn0wnGh0st333
Copy link
Contributor Author

@dvir001 I can't figure out what I'm missing, bless me with your frontier knowledge

@dvir001
Copy link
Contributor

dvir001 commented Dec 23, 2024 •
edited
Loading

You dont need whitelisted.yml

@ewokswagger
Copy link
Contributor

This is so cute I'm all for more pets

@Kr8art
Copy link
Contributor

Kr8art commented Dec 25, 2024

Can Clippy actually deliver mail? Would be funny if people would be able to take it as ghost role and started dragging letters around.

dvir001
dvir001 reviewed Dec 25, 2024
View reviewed changes
Resources/Prototypes/_NF/Entities/Clothing/Back/base_clothing_backpack.yml
- type: Item
size: Huge
shape:
- 0,0,6,3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file and proto isn't needed, its just a normal backpack at that point, remove this file

dvir001
dvir001 reviewed Dec 25, 2024
View reviewed changes
Resources/Prototypes/_NF/Entities/Clothing/Back/backpacks.yml
@@ -0,0 +1,11 @@
- type: entity
parent: NFClothingBackpack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parent ClothingBackpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvir001 dvir001 dvir001 left review comments

@Lyndomen Lyndomen Lyndomen requested changes

@deltanedas deltanedas deltanedas approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Changes: Audio Changes any audio files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Unkn0wnGh0st333 @dvir001 @ewokswagger @Kr8art @deltanedas @Lyndomen