Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Radio Channel #2373

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Unkn0wnGh0st333
Copy link
Contributor

@Unkn0wnGh0st333 Unkn0wnGh0st333 commented Dec 6, 2024

About the PR

Ports the Traffic Radio Channel and Pilot Outfit from Frontier

Why / Balance

Traffic Coms were per request of several people in the discord and some of Direction enjoyed the idea.
The pilot uniform is 100% necessary and the entirety of everything depends on its existence cause how can you have flying ships and not have pilots.

Technical details

  • Traffic Radio Channel
  • Channel added to LO headset
    ❌ Channel connected to the Command Key
  • Intercoms for the Channel
  • Channel Key
    ❌ Channel Key Box in LO's Locker
  • Channel Key Box for sale for 10k
  • Pilot Uniform (Includes full outfit + Hardsuit

❌ Shuttle Console Traffic Coms (Could not get it to work for the life of me, good luck to whoever can fix it)

Media

image
image
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

This will require SOP modifications involving the channel. It is a long-range communication and is only accessible from LO locker and the command key. It should be added to every shuttle for legality reasons until someone can make it so shuttle consoles are also intercoms. This will also need possible rule protection to prevent people from using it during certain events such as solar flares and others. This is not a channel for talking, it is a channel for traffic and has to be treated that way.

Changelog
🆑

  • Traffic Radio Channel has been installed in the DeltaV Sector. Make sure to give your Cargo Pilots the key, LO!

@Unkn0wnGh0st333 Unkn0wnGh0st333 requested review from IamVelcroboy and a team as code owners December 6, 2024 13:23
@github-actions github-actions bot added size/L 256-1023 lines S: Needs Review Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi and removed S: Needs Review labels Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

RSI Diff Bot; head commit cd2e3bc merging into 9db6651
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Clothing/Back/Backpacks/pilot.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Duffels/pilot.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Satchels/pilot.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Belt/pilot.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Ears/Headsets/pilot.rsi

State Old New Status
alt-equipped-EARS Added
icon_alt Added

Resources/Textures/_NF/Clothing/Eyes/Glasses/pilot.rsi

State Old New Status
equipped-EYES Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Hands/Gloves/pilot.rsi

State Old New Status
equipped-HAND Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Head/Hardsuits/pilot.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
off-inhand-left Added
off-inhand-right Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added
on-inhand-left Added
on-inhand-right Added

Resources/Textures/_NF/Clothing/Head/Hats/pilot.rsi

State Old New Status
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Mask/pilot.rsi

State Old New Status
equipped-MASK-vox Added
equipped-MASK-vulpkanin Added
equipped-MASK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Neck/Scarfs/pilot.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/OuterClothing/Hardsuits/pilot.rsi

State Old New Status
equipped-OUTERCLOTHING-monkey Added
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Shoes/Boots/pilot.rsi

State Old New Status
equipped-FEET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Uniforms/Jumpsuit/pilot.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
equipped-INNERCLOTHING-vox Added
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Objects/Devices/encryption_keys.rsi

State Old New Status
crypt_gray Added
stc_label Added

Resources/Textures/_NF/Structures/Storage/closet.rsi

State Old New Status
generic Added
generic_door Added
locked Added
pilot Added
pilot_door Added
pilot_open Added
sparking Added
unlocked Added
welded Added

Edit: diff updated after cd2e3bc

@dvir001
Copy link
Contributor

dvir001 commented Dec 6, 2024

Please note the new PR's on frontier to fix locker + mask yml cleanups

Copy link
Member

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern here is that it adds a long range radio channel (which historically has been limited only to syndicate) to all of command, making killing people during FTL (and possibly jammers too, not entirely sure) useless.
Even if it's not intended to be used that way, banning someone over using a radio channel they have access to just seems silly.

@Radezolid
Copy link
Contributor

Let the captain be the only one with the key on their headset and place intercoms on shuttles

@ewokswagger
Copy link
Contributor

Could this also be done via putting fax machines on trader ships?

@Lyndomen
Copy link
Contributor

Ok gamer, can you:
Separate Traffic from Command. It should be independent
Remove Traffic Key box from LO
Add Traffic to AI
Add Traffic to Master Key

Add new logi purchase for a traffic key, 10,000 spesos or whatever

@Unkn0wnGh0st333 Unkn0wnGh0st333 mentioned this pull request Dec 12, 2024
2 tasks
@Lyndomen Lyndomen added the S: Approved Approved direction-wise, pending code review. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Approved Approved direction-wise, pending code review. S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants