Unique DeltaV borg names! #2371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
Changes: YML
MilonPL
suggested changes
Dec 5, 2024
| @@ -30,4 +30,4 @@ | |||
| name: power-cell-slot-component-slot-name-default | |||
| startingItem: PowerCellMedium | |||
| - type: RandomMetadata | |||
| nameSegments: [names_borg] # TODO: Make good names, this is a stupid list. | |||
| nameSegments: [names_borg_deltav] # TODO: Make good names, this is a stupid list. # Your wish is my command, unknown commenter -Fox | |||
There was a problem hiding this comment.
just remove the comment so it wont show on TODOs
There was a problem hiding this comment.
the comment intent was to have secborg with less goofy names, not that this pr is bad just saying
also remove the comments yes
| @@ -453,7 +453,7 @@ | |||
| name: power-cell-slot-component-slot-name-default | |||
| startingItem: PowerCellMedium | |||
| - type: RandomMetadata # DeltaV: give job borgs names | |||
There was a problem hiding this comment.
change the comment to # DeltaV - summary while you're at it for the sake of my OCD
There was a problem hiding this comment.
pro I diddnt write that but sure
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
move it to borg chassis now that its defined on that instead of player spawn one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Much like the AI names, adds a custom list of borg names for DeltaV
Why / Balance
Server Identity
A code comment told me to
Funny
Technical details
Media
Requirements
Breaking changes
Changelog
🆑 Fox