-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hushed trait #2106
Add hushed trait #2106
Conversation
All changes should be resolved now. |
I think the fails are fake? Since it worked since I just added the spaces and re-added a couple usings. |
Head branch was pushed to by a user without write access
I can already seeing people stacking this with stuttering on their little nerds heh |
I have a character in mind for this already, though I would like to see a more severe version of stuttering, as the one we have is very mild, to the point I wouldn't really call it stutter. |
This could be remedied fairly easily by changing the values here.
|
@deltanedas Is there anything else I need to do? |
About the PR
Added new Hushed trait. A 0 cost speech trait which gives a HushedComponent that causes local messages to be converted to whispers.
Why / Balance
Several players have characters that are soft-spoken or shy and this gives another option to express that. This trait can help consistency in character by avoiding accidental local chats from players who take this trait.
Technical details
Added Hushed trait and component. Added logic in TrySendInGameICMessage to check if someone has the HushedComponenet and intends to send in local, and changes it to a whisper. Applied after checking and removing local prefix.
Media
2024-11-03.18-58-52.mp4
Requirements
Breaking changes
None
Changelog
🆑 SolStar2, Vivi Bunny