-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random solar spawners #2096
Open
Radezolid
wants to merge
3
commits into
DeltaV-Station:master
Choose a base branch
from
Radezolid:spawner-random-solars
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Status: Needs Review
Changes: YML
Changes any yml files
Changes: Sprite
Changes any png or json in an rsi
labels
Nov 2, 2024
IamVelcroboy
reviewed
Nov 2, 2024
Resources/Prototypes/DeltaV/Entities/Markers/Spawners/Random/solar.yml
Outdated
Show resolved
Hide resolved
deltanedas
requested changes
Nov 3, 2024
Comment on lines
1
to
12
{ | ||
"version":1, | ||
"license":"CC-BY-SA-3.0", | ||
"copyright":"Taken from https://github.com/discordia-space/CEV-Eris/blob/d1e0161af146835f4fb79d21a6200caa9cc842d0/icons/obj/power.dmi and modified. Modified by Radezolid for random solar spawner", | ||
"size":{"x":32,"y":32}, | ||
"states": | ||
[ | ||
{ | ||
"name": "random_solar" | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
untroll all the json formatting so its like other files
deltanedas
added
Status: Awaiting Changes
Do not merge due to requested changes
and removed
Status: Needs Review
labels
Nov 3, 2024
github-actions
bot
added
Status: Needs Review
and removed
Status: Awaiting Changes
Do not merge due to requested changes
labels
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: Sprite
Changes any png or json in an rsi
Changes: YML
Changes any yml files
Status: Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
I want to add a new spawner for solars.
Why / Balance
More mapping freedom.
Technical details
Added a new spawner.
Media
Requirements
Breaking changes
None.
Changelog
no cl.