Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Block emotes for sleeping" (#32779) #2084

Merged

Conversation

Radezolid
Copy link
Contributor

About the PR

Reverted "Block emotes for sleeping" per asking of WYCI Suggestion.

Why / Balance

The emote system apparently was being abused in LRP when you got slept, as a MRP server we should have less problems with it while it helps with RP of narcoleptic people.

Technical details

Commented out the PRs added lines out of SleepingSystem.cs.

Media

2024-11-01.09-07-21.mp4

Requirements

Breaking changes

Changelog

🆑

  • tweak: You can use emotes while sleeping to enhance narcoleptic RP.

@Radezolid Radezolid requested a review from a team as a code owner November 1, 2024 12:11
@Radezolid Radezolid changed the title Reverted "Block emotes for sleeping" (upstream PR #32779) Revert "Block emotes for sleeping" (upstream PR #32779) Nov 1, 2024
@MilonPL MilonPL changed the title Revert "Block emotes for sleeping" (upstream PR #32779) Revert "Block emotes for sleeping" (#32779) Nov 1, 2024
@Lyndomen
Copy link
Contributor

Lyndomen commented Nov 1, 2024

I have never seen this be overly abused here; I wholeheartedly support this as someone who was very confused why I couldn't *snore.

@deltanedas deltanedas added Status: Awaiting Changes Do not merge due to requested changes and removed Status: Needs Review labels Nov 3, 2024
@deltanedas deltanedas merged commit dc3a3ca into DeltaV-Station:master Nov 3, 2024
11 checks passed
@Radezolid Radezolid deleted the Revert-Block-emotes-for-sleeping branch November 3, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Status: Awaiting Changes Do not merge due to requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants