Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TraitorReinforcementRemoval #2062

Conversation

Solaris7518
Copy link
Contributor

About the PR

Disables an event that is just a worse version of sleeper agents.

Why / Balance

This event is just sleeper agents but they dont get uplinks, which makes zero sense.

Technical details

Comments out a worse version of the sleeper agents.

Media

N/A

Requirements

Breaking changes

N/A

Changelog

🆑

  • remove: Removed an event that is what I can only describe as the sleeper agents but worse.

@Solaris7518 Solaris7518 requested a review from a team as a code owner October 28, 2024 00:13
@deltanedas
Copy link
Member

deltanedas commented Oct 28, 2024

this doesnt do anything, if it was an actual event it would be in an event table. this is just a rule (unused i think) for reinforcements to be added to

@Solaris7518
Copy link
Contributor Author

@deltanedas Unfortunately, it does work, as it got added by the event scheduler as an gamerule during round #16413 (Round that happened today on apoapsis), resulting in a player becoming a syndicate agent with no uplink and objectives.
See aforementioned picture of the gamerule being active on apoapsis.
image_2024-10-27_195731130

@deltanedas
Copy link
Member

reinforcements arent supposed to have uplinks or random objectives (ideally it would be assist the person that called you in)
if reinforcements are spawning in events somehow thats a separate issue

@Solaris7518
Copy link
Contributor Author

Solaris7518 commented Oct 28, 2024

@deltanedas
Apologies, but I don't think I said that right. Is what I meant to say is that the gamerule is not trying to spawn in syndicate reinforcements, its turning people into syndicate agents (with objectives) without uplinks.

@deltanedas
Copy link
Member

there is no event for it, it only gets added by reinforcement monkey/kobold/human spawning
02:19:05

what would be a bug is when that rule being added, it picks players that aren't the actual reinforcement. but that would be an upstream issue too

@Solaris7518
Copy link
Contributor Author

I see... Well, I guess I can go ahead and close the pr, seeing as this may be a upstream issue, from the looks of it, Ill look into getting an bug report opened upstream so that the issue can hopefully be fixed there.

@Solaris7518 Solaris7518 deleted the TraitorReinforcementRemoval branch October 28, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants