Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mail jobs not being localized #2060

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

deltanedas
Copy link
Member

About the PR

right now only happens for alt titles but if other jobs actually got localized it would matter too

@deltanedas deltanedas requested a review from a team as a code owner October 27, 2024 23:00
@MilonPL MilonPL enabled auto-merge (squash) October 28, 2024 09:27
@MilonPL MilonPL merged commit b9d6595 into DeltaV-Station:master Oct 28, 2024
11 checks passed
@deltanedas deltanedas deleted the mail-title-ops branch October 28, 2024 10:03
@MilonPL
Copy link
Contributor

MilonPL commented Oct 28, 2024

image
@deltanedas jinxed it

@deltanedas
Copy link
Member Author

?? "" ops

@MilonPL
Copy link
Contributor

MilonPL commented Oct 28, 2024

?? "" ops

my original idea was to do ?? "Unknown" ops but I decided to refactor the entire thing after seeing 70 warnings in the mailsystem.cs so that should be done at some point today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants