Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Syrinx implant #2055

Merged
merged 5 commits into from
Nov 3, 2024

Conversation

beck-thompson
Copy link
Contributor

About the PR

Implant was broken, fixed it and made the system a lot cleaner to boot!

Technical details

Made the transform speaker event get passed through to implants, and also made the implanter use the normal voice mask UI and stuff instead of doing any copy pasting weirdness!

Media

Changelog

🆑

  • fix: Syrinx implant now works correctly

@beck-thompson beck-thompson requested review from a team as code owners October 27, 2024 06:43
@github-actions github-actions bot added Status: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files labels Oct 27, 2024
Content.Server/DeltaV/Implants/SyrinxImplantSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Implants/SyrinxImplantSystem.cs Outdated Show resolved Hide resolved
Content.Shared/Implants/SharedSubdermalImplantSystem.cs Outdated Show resolved Hide resolved
Content.Shared/Implants/SharedSubdermalImplantSystem.cs Outdated Show resolved Hide resolved
Resources/Prototypes/DeltaV/tags.yml Outdated Show resolved Hide resolved
Content.Server/DeltaV/Implants/SyrinxImplantSystem.cs Outdated Show resolved Hide resolved
@deltanedas deltanedas added Status: Awaiting Changes Do not merge due to requested changes and removed Status: Needs Review labels Nov 3, 2024
@beck-thompson
Copy link
Contributor Author

Did that fix the weird issue in tags.yml? Commit 3ab54ad says I added the space but the PR says I didn't... I'm so confused

@beck-thompson
Copy link
Contributor Author

It worked thanks!🫡

@deltanedas deltanedas enabled auto-merge (squash) November 3, 2024 17:59
@deltanedas deltanedas merged commit 4d81976 into DeltaV-Station:master Nov 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Awaiting Changes Do not merge due to requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants