Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OOC on Horizon #2050

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

perryprog
Copy link
Contributor

About the PR

Enabled OOC during rounds on Horizon.

Why / Balance

Horizon is usually either small population of periapsis overflow, often both at the same time. Since this is often a place people will go to learn a new role, having a way to ask OOC questions about mechanics is often very desirable. I don't see any real downside to having it enabled by default here, especially considering it's usually fine on periapsis.

Technical details

Tested offline, loads fine when horizon is set the config preset.

Media

Requirements

Breaking changes

None.

Changelog

Don't think a changelog is needed.

@perryprog
Copy link
Contributor Author

Test failure fake. (Mind role stuff.)

@makyo
Copy link

makyo commented Oct 27, 2024

Guh, thank you.

Copy link
Contributor

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Host approved.

@MilonPL MilonPL enabled auto-merge (squash) October 28, 2024 09:59
@MilonPL MilonPL merged commit 905d686 into DeltaV-Station:master Oct 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants