Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use LocalizedJobTitle in crew manifest #2037

Merged
merged 1 commit into from
Oct 24, 2024
Merged

use LocalizedJobTitle in crew manifest #2037

merged 1 commit into from
Oct 24, 2024

Conversation

deltanedas
Copy link
Member

About the PR

title

Why / Balance

so it localizes

Technical details

:trollface:

Media

Requirements

Breaking changes

no

Changelog
🆑

  • fix: Fixed the crew manifest.

@deltanedas deltanedas requested a review from a team as a code owner October 24, 2024 12:27
@MilonPL
Copy link
Contributor

MilonPL commented Oct 24, 2024 •
edited
Loading

station records are fucked too

Delta-v/Content.Server/StationRecords/Systems/StationRecordsSystem.cs

Line 162 in dcc4198

JobTitle = card?.Comp.JobTitle ?? jobPrototype.LocalizedName, // DeltaV
is the issue (should use LocalizedJobTitle if it's not null or JobTitle otherwise)

@deltanedas
Copy link
Member Author

so its just records not crew manifest (also that field didnt exist real)

@MilonPL MilonPL enabled auto-merge (squash) October 24, 2024 12:35
@MilonPL MilonPL merged commit 7ab6ff1 into DeltaV-Station:master Oct 24, 2024
11 checks passed
@deltanedas deltanedas deleted the manifest-ops branch October 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilonPL MilonPL MilonPL approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deltanedas @MilonPL