Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream merge 24/10 #2036

Merged
merged 156 commits into from
Oct 24, 2024
Merged

upstream merge 24/10 #2036

merged 156 commits into from
Oct 24, 2024

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Oct 24, 2024

Notable additions

  • mind roles as entities, this might cause some sneaky bugs but i think i updated everything
  • ftldisk command for admin abuse
  • zombie blood isnt a massive pita anymore
  • truncheon does stamina damage on wide swing
  • automatic restart after 48h of uptime to prevent memory leak trolling if theres no updates @MilonPL
  • syringe gun for admin abuse

Notable exclusions

  • commented out intellicard from mg locker until AI is enabled
  • ghost locator removed from maints spawn

Changelog
🆑

  • add: Merged the past few weeks changes from upstream, report any bugs related to your character menu or objectives!

lzk228 and others added 30 commits October 24, 2024 00:08
* Fix cryo locale again

* yeep
Update curtains.yml
…32683)

changed punctuation for jobs, added proper capitalization and comma usa
* swap omega and delta particle colours

* remove upgrade doafter

* explicit syndicate chip description

* Syndicate CHIMP stealth

* fast projectile speed

* 10 to 12 shots

* buff heat dmg

* upgrade chip mentions omega particle

* Revert "remove upgrade doafter"

This reverts commit 8a321980b7a384daca06215656494e0c116e7333.

* Revert "explicit syndicate chip description"

This reverts commit c803c773739a61fc5b3a6cb90810622a6d5846c9.

* Revert "Syndicate CHIMP stealth"

This reverts commit 698a108580892addabf8d51494a72e1ee651b8e6.

* Revert "10 to 12 shots"

This reverts commit 858ac0392be0549eb0a288648413d1020cabae1a.

* Revert "swap omega and delta particle colours"

This reverts commit 4c000b2f110a5d35f317cb61cb5b03ea32841ad5.

* Revert "buff heat dmg"

This reverts commit 02a8690dafbd41631b098e51ef9afba5b6ee6ac4.
* first commit

* Licence fix

* rosysyntax licence change (permission granted!)

* simplify

* Better wording
* initial commit

* Delta review
* First commit

* increase price by one tc
* Job title localization

* Correcting fields
* First commit

* I forgot silly me

* Actually added comments

* spellin

* fixes

* more blacklists

* Minor fixes

* Speech Verb also changes now

* Simple name stuff

* Other fixes

* remove one line of whitespace

---------

Co-authored-by: slarticodefast <[email protected]>
…32723)

* Fix error log when recycling something with small material counts.

MaterialStorageSystem.SpawnMultipleFromMaterial now doesn't call StackSystem.SpawnMultiple if it tries to spawn zero. This happens because the recycler calls SpawnMultipleFromMaterial for everything recycled, even if the amount it has stored is < the amount for one sheet.

* Update Content.Server/Materials/MaterialStorageSystem.cs

Co-authored-by: slarticodefast <[email protected]>

---------

Co-authored-by: slarticodefast <[email protected]>
* Mind Role Entities wip

* headrev count fix

* silicon stuff, cleanup

* exclusive antag config, cleanup

* jobroleadd overwerite

* logging stuff

* MindHasRole cleanup, admin log stuff

* last second cleanup

* ocd

* minor cleanup

* remove createdTime datafield

* now actually using the event replacement I made for role time tracking

* weh
* Make NameIdentifier Ids get refreshed after round restarts

Before this commit the existing values would just get shuffled.
This means that eventually the server would run out of ids to give to
new entities for different groups. As a result everything would get id 0

* Comply with what seemingly is the convention for sawmills

* Make it impossible to insert a bounty with a duplicate id

* Reduce duplication

* Remove unused sawmill

* Fix rustbrain and skill issue

* Aaaa

* Apply suggestions from code review

---------

Co-authored-by: Pieter-Jan Briers <[email protected]>
* Fix Centcom cloning scanner

* Fix uid conflict
It's simple. We kill the heisentest
* Make APC UI work correctly with multiple users

* Check access only on client, when constructing UI

* Do TODO (Thanks, Robust 236.1)

---------

Co-authored-by: Eoin Mcloughlin <[email protected]>
@deltanedas deltanedas requested review from a team and IamVelcroboy as code owners October 24, 2024 01:39
@github-actions github-actions bot added Status: Needs Review Changes: YML Changes any yml files Changes: Map Changes: UI Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Documentation Changes any xml or md files Changes: Sprite Changes any png or json in an rsi Changes: Audio Changes any audio files and removed Status: Needs Review labels Oct 24, 2024
@therealDLondon
Copy link
Member

Ima be real I dont like the ghost detector should probably get rid of that lmao

Copy link
Contributor

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else looks good

Content.Shared/DeltaV/Recruiter/RecruiterPenComponent.cs Outdated Show resolved Hide resolved
Content.Shared/DeltaV/Recruiter/RecruiterPenComponent.cs Outdated Show resolved Hide resolved
@MilonPL
Copy link
Contributor

MilonPL commented Oct 24, 2024

ok stupid centcomm map left, i sent what's causing it in #mapping

deltanedas and others added 5 commits October 24, 2024 09:18
* Fix bug?

* Fix :)

* aaaa

* AAAA!!!

* comment

* Nicer code

* What's a pull requestWhat's a pull request?
Copy link
Contributor

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuck it we ball

@MilonPL MilonPL merged commit c1ef4bc into DeltaV-Station:master Oct 24, 2024
11 checks passed
@deltanedas deltanedas deleted the upstream-ops branch October 24, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Map Changes: Sprite Changes any png or json in an rsi Changes: UI Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.