Split Emag in half #1426
Merged
Split Emag in half #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: YML
doesnt tg have it |
it does but it also has different cryptographic sequencer and id card sprites which would look out of place here. i guess i could use it temporarily for testing but i dont know how attributions work so i dont want to bother lol. |
Signed-off-by: WarMechanic <[email protected]>
|
I think the admin team is really excited about this, and look forward to it if it is implemented. |
DEATHB4DEFEAT
previously requested changes
Jun 28, 2024
deltanedas
requested changes
Jun 28, 2024
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: WarMechanic <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: WarMechanic <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: WarMechanic <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: WarMechanic <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: WarMechanic <[email protected]>
|
all requested changes are resolved, all checks have passed and it still works in game so it looks good to me |
|
only a week away |
|
@deltanedas @DEATHB4DEFEAT Have your things been properly addressed? |
deltanedas
approved these changes
Jul 6, 2024
NullWanderer
approved these changes
Jul 9, 2024
ProphetCrow
added a commit
to ProphetCrow/Delta-v-testenv
that referenced
this pull request
Jul 10, 2024
This reverts commit 4227c24. # Conflicts: # Resources/Locale/en-US/deltav/store/uplink-catalog.ftl # Resources/Prototypes/DeltaV/Catalog/uplink_catalog.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Splits the functionality of Emag into two different items:
Why / Balance
Emag is a very big item which makes it hard to balance. On one hand, its a gimmick enabler by creating special interactions with station machines. On the other hand, it is very efficient at breaking and entering anywhere with a door. Most players will want to buy the Emag for one function or the other.
By splitting Emag into these two functions, the collective cost of Emag will stay at 10 but Syndicate players will have more agency over what they want to do in a round with budget cuts. The cost of either item can be interpolated based on which one is more powerful.
Technical details
Adds whitelist and blacklist variables to the Emag component.
Media
https://youtu.be/c0NuEvLdc_U
Breaking changes
No
Changelog
🆑