Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attorney and HoS PDA locale fix #1381

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

Timemaster99
Copy link
Contributor

About the PR

Fixes #1372 with the added bonus of the HoS PDA

Why / Balance

Technical details

Changed an ftl file

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog
Capitalization, doesn't need a CL

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Localization Changes any ftl files labels Jun 14, 2024
@NullWanderer
Copy link
Contributor

Why is it localized like this instead of being in the entity prototype like its supposed to be

@deltanedas
Copy link
Member

yeah nothing else e.g. mysta items does this they just do name: ...

@Timemaster99
Copy link
Contributor Author

Why is it localized like this instead of being in the entity prototype like its supposed to be

They are both upstream entities. Doing this overwrites their name and prevents any conflicts

@NullWanderer NullWanderer merged commit 0e9bbfb into DeltaV-Station:master Jul 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attorney PDA lacks capitalisation
3 participants