shipyard ui cleanup #1257
Open
shipyard ui cleanup #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2024 05:42
github-actions
bot
added
Changes: YML
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: deltanedas <[email protected]>
|
sighs merging master did not fix the checks. is this still something you plan on working on @deltanedas? |
|
forgot this wasnt done |
|
Well all the checks are passed. I'm no C# expert but hey, if it works on your machine :blunt: |
|
forgor |
|
doesn't work :blunt: |
|
requires space-wizards/space-station-14#33123 |
|
@deltanedas fixed your shit
(needs a 3rd independent c# maintainer to review it now, oh wait) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
needs space-wizards/space-station-14#28295 cherry picked
Why / Balance
not having to reopen to see latest balance good
Technical details
uses new BankBalanceUpdatedEvent
Media
Breaking changes
ShipyardConsole needs BankClient now
Changelog
no cl no fun