New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration validation in DeeplayModule #37

Merged

giovannivolpe merged 1 commit into develop from bm/reduce-strictness-if-variadic

Dec 14, 2023

Collaborator

BenjaminMidtvedt commented Dec 14, 2023

Fixes an issue with Layer where classes with **kwarg signatures could only be configured with names given on initial construction. For example

layer = dl.Layer(torch.nn.LSTM, input_size=10, hidden_size=20, num_layers=2)
layer.configure(bidirectional=True)
layer.build()

would not recognize bidirectional as a valid configurable. Now, we allow any keyword configurable as if the class has **kwargs in it's signature.


          Fix configuration validation in DeeplayModule

740fd83

giovannivolpe merged commit adbbefd into develop

12 checks passed

giovannivolpe deleted the bm/reduce-strictness-if-variadic branch

December 14, 2023 13:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet