Bugs in GANs #103
Merged
Bugs in GANs #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed pool layers
Instance norm should not be there in the last layer
Spelling mistakes!!! (Because of which activations were not being applied properly)
Changed the dimensions of the hidden channels
Embedding layer missing from weight initialization.
giovannivolpe
requested review from
cmanzo,
Henrik-KM,
JesusPinedaC,
BenjaminMidtvedt and
giovannivolpe
|
I've reviewed the changes and I think they look good, especially if the examples work as expected now. However, I suggest that we implement unit tests for both CycleGAN and DCGAN. This will help us keep track of any possible changes to the models. The unit tests can be quite simple and focus on evaluating the correct order of operations, expected number of layers, and appropriate output dimensions of the model. |
giovannivolpe
approved these changes
May 6, 2024
Normalization is applied only to the weights and not biases
Normalization is now applied only to the weights and not biases. Removed nn.Linear layer from the normalization as it does not exist in dcgan generator.
|
Hi! @JesusPinedaC I have created the unit tests now, and adjusted few other minor things. The models are working as expected now, and the weights are being initialized properly for dcgan. If everything looks good, I think this can be merged now. |
|
These are excellent unittests! @HarshithBachimanchi Everything looks good to me. |
JesusPinedaC
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.