Merge pull request #342 from DeclareDesign/cran-patch

cran patch
DeclareDesign · Mar 23, 2020 · d90e147 · d90e147
2 parents a4bfb48 + 5ed9a63
commit d90e147
Show file tree

Hide file tree

Showing 22 changed files with 172 additions and 58 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: estimatr
 Type: Package
 Title: Fast Estimators for Design-Based Inference
-Version: 0.20.0
+Version: 0.22.0
 Authors@R: c(person("Graeme", "Blair", email = "[email protected]", role = c("aut", "cre")),
              person("Jasper", "Cooper", email = "[email protected]", role = c("aut")),
              person("Alexander", "Coppock", email = "[email protected]", role = c("aut")),
@@ -23,7 +23,7 @@ Imports:
     rlang (>= 0.2.0)
 LinkingTo: Rcpp, RcppEigen
 Encoding: UTF-8
-RoxygenNote: 6.1.1
+RoxygenNote: 7.1.0
 LazyData: true
 Suggests:
     fabricatr (>= 0.10.0),

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,8 @@
-# estimatr 0.20.0 (CRAN)
+# estimatr 0.22.0 
+
+* Bug fixes
+
+# estimatr 0.20.0 
 
 * Added support for `emmeans` (thanks @rvlenth)!
 * Fixed bug when estimating `diagnostics` in `iv_robust()` without explicitly specifying `se_type` (issue #310)

diff --git a/R/estimatr.R b/R/estimatr.R
@@ -1,5 +1,7 @@
 #' estimatr
 #'
+#' @description Fast procedures for small set of commonly-used, design-appropriate estimators with robust standard errors and confidence intervals. Includes estimators for linear regression, instrumental variables regression, difference-in-means, Horvitz-Thompson estimation, and regression improving precision of experimental estimates by interacting treatment with centered pre-treatment covariates introduced by Lin (2013) <doi:10.1214/12-AOAS583>.
+#'
 #' @docType package
 #' @useDynLib estimatr, .registration = TRUE
 #' @importFrom Rcpp evalCpp

diff --git a/R/helper_na_omit_detailed.R b/R/helper_na_omit_detailed.R
@@ -1,7 +1,6 @@
 #' Extra logging on na.omit handler
 #'
 #' @param object a data.frame
-#' @param ... unused
 #'
 #' @return a normal \code{omit} object, with the extra attribute \code{why_omit},
 #' which contains the leftmost column containing an NA for each row that was dropped, by

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,8 +1,6 @@
 ## Submission
 
-We are resubmitting a small update, `estimatr 0.20.0`, with bug fixes and the addition of a small new feature.
-
-We have now fixed issues related to Solaris builds, MKL, and OpenBLAS. Apologies for the back and forth.
+This small patch addresses errors on CRAN related to changes in stringsAsFactor and we think resolves all issues. 
 
 Thank you for your time reviewing the submission.
 
@@ -11,6 +9,7 @@ Thank you for your time reviewing the submission.
 * ubuntu on travis-ci (devel, release, oldrel)
 * OS X on travis-ci (release, oldrel)
 * win-builder (devel, release, oldrel)
+* rhub (including Solaris)
 
 ## R CMD check results
 

diff --git a/man/alo_star_men.Rd b/man/alo_star_men.Rd
diff --git a/man/commarobust.Rd b/man/commarobust.Rd
diff --git a/man/declaration_to_condition_pr_mat.Rd b/man/declaration_to_condition_pr_mat.Rd
diff --git a/man/difference_in_means.Rd b/man/difference_in_means.Rd
diff --git a/man/estimatr.Rd b/man/estimatr.Rd
diff --git a/man/extract.lm_robust.Rd b/man/extract.lm_robust.Rd
diff --git a/man/horvitz_thompson.Rd b/man/horvitz_thompson.Rd
diff --git a/man/iv_robust.Rd b/man/iv_robust.Rd
diff --git a/man/lh_robust.Rd b/man/lh_robust.Rd
diff --git a/man/lm_lin.Rd b/man/lm_lin.Rd
diff --git a/man/lm_robust.Rd b/man/lm_robust.Rd
diff --git a/man/lm_robust_fit.Rd b/man/lm_robust_fit.Rd
diff --git a/man/na.omit_detailed.data.frame.Rd b/man/na.omit_detailed.data.frame.Rd
diff --git a/man/predict.lm_robust.Rd b/man/predict.lm_robust.Rd
diff --git a/man/starprep.Rd b/man/starprep.Rd