Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log DVM hash without undos #3109

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Log DVM hash without undos #3109

merged 2 commits into from
Nov 4, 2024

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Nov 4, 2024

Summary

  • Hashes DVM DB without undos which were changed from the 4.1.0 release onwards. This PR then allows us to compare nodes using the hash without undos which should match regardless of whether they were synced with 4.1.0+ or not.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

prasannavl
prasannavl reviewed Nov 4, 2024
View reviewed changes
src/dfi/rpc_accounts.cpp Outdated Show resolved Hide resolved
@prasannavl prasannavl merged commit bd0177d into master Nov 4, 2024
13 of 14 checks passed
@prasannavl prasannavl deleted the bush/hash-no-undo branch November 4, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl prasannavl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bushstar @prasannavl