Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize ERC55 terminology #2293

Merged
merged 27 commits into from
Aug 8, 2023
Merged

Normalize ERC55 terminology #2293

merged 27 commits into from
Aug 8, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Aug 6, 2023

Summary

  • Normalizes terminology to ERC55
  • Allow listing normal balances in ERC55
    • Restored to not show ERC55 in listreceivedby, as it's not allowed on mainnet due to non-standard TX
    • For other networks, we should still flag it later to enable on RPC. But leaving it for now to add it later.

Based on #2291

RPC

  • getaccount:
    • Changed include_eth to evm.
    • Note that this only includes EVM native (DFI) balance. Does not include DST20.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

Bushstar
Bushstar previously approved these changes Aug 8, 2023
@prasannavl prasannavl merged commit e9a6ccb into master Aug 8, 2023
11 of 13 checks passed
@prasannavl prasannavl deleted the pvl/erc55-normalize branch August 8, 2023 12:38
@prasannavl prasannavl changed the title Normalize ERC55 terminology and enable listing received Normalize ERC55 terminology Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants