Feature/87 add status script #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 17, 2018 23:59
# Conflicts: # mcpartools/mcengine/data/run_shieldhit.sh
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 63.82% 61.01% -2.82%
==========================================
Files 12 13 +1
Lines 868 967 +99
Branches 0 150 +150
==========================================
+ Hits 554 590 +36
- Misses 314 315 +1
- Partials 0 62 +62
Continue to review full report at Codecov.
|
|
Log files at written in running directory, I'd rather expect them to be written in the workspace: |
|
I'd also expect the status script to print on the screen basic information, like: In the log file more details should be dumped. It is not necessary to write it to separate file each time (single status.log is enough) |
grzanka
reviewed
Nov 9, 2018
| @@ -11,13 +11,14 @@ ERR=`mktemp` | |||
| # On exit or if the script is interrupted (i.e. by receiving SIGINT signal) delete temporary files | |||
| trap "rm -f $OUT $ERR" EXIT | |||
|
|
|||
| qsub {options_args:s} -t 1-{jobs_no:d} -o {log_dir:s} -e {log_dir:s} -terse {script_dir:s}/{calculate_script_name:s} > $OUT 2> $ERR | |||
grzanka
reviewed
Nov 9, 2018
|
|
||
| if [[ ${{SUCCESSES}} -ne 0 ]] | ||
| then | ||
| echo "# AVERAGE TIME [s]= `printf "%20d" $(($TOTAL_TIME / $SUCCESSES))`" >> ${{LOG_FILE}} |
There was a problem hiding this comment.
Time of longest job would be nice to have
grzanka
reviewed
Nov 9, 2018
mcpartools/generator.py
Outdated
| @@ -242,3 +248,15 @@ def save_logs(self): | |||
| file_logger.info('Date and time: ' + time.strftime("%Y-%m-%d %H:%M:%S")) | |||
| file_logger.info('username@hostname: ' + getpass.getuser() + '@' + socket.gethostname()) | |||
| file_logger.info('Current working directory: ' + os.getcwd()) | |||
|
|
|||
| def generate_merge_logs_script(self): | |||
| wspdir_name = 'workspace' | |||
There was a problem hiding this comment.
Take a look some lines above:
def generate_workspace(self):
wspdir_name = 'workspace'
this would be a second use of this hardcoded string. Third one will be below in generate_status_script.
I'd recommend to extract it to a class variable in order not to break DRY rule.
grzanka
reviewed
Nov 9, 2018
mcpartools/scheduler/common.py
Outdated
| @@ -16,6 +16,7 @@ def __init__(self): | |||
| @classmethod | |||
| def get_scheduler(cls, scheduler_options, log_location): | |||
| file_logger = logging.getLogger('file_logger') | |||
|
|
|||
There was a problem hiding this comment.
Please avoid commiting extra empty lines
|
Final thoughts/tasks:
|
added 6 commits
November 12, 2018 10:42
…to feature/87-add-status-script
…to feature/87-add-status-script
…to feature/87-add-status-script
|
Try running the submit script, but please deliberately forget to type In this case all jobs will fail, as While in the log files there is a clear message: |
|
Executing status script while jobs are running in normal mode also ends up with weird message: |
|
I've did another stupid thing: started submit script from worker node. Of course the submission failed (it can be only done from login node). But the status script showed me some strange message: I'd rather expect a single line telling me that the submission failed and no jobs are in running or pending state. |
added 3 commits
November 23, 2018 18:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #87