This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
Use a dedicated timeout for each package #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlyF
reviewed
Jun 21, 2018
docs/pupernetes_daemon_run.md
Outdated
| @@ -44,8 +44,8 @@ pupernetes daemon run state/ --job-type systemd | |||
| --gc duration grace period for the kubelet GC trigger when draining run, no-op if not draining (default 1m0s) | |||
| -h, --help help for run | |||
| --job-type string type of job: fg or systemd (default "fg") | |||
| --run-timeout duration timeout for run (default 7h0m0s) | |||
There was a problem hiding this comment.
--run-timeout duration Maximum time to run pupernetes for until self shutdown
docs/pupernetes_wait.md
Outdated
| -u, --unit-to-watch string Systemd unit name to watch (default "pupernetes.service") | ||
| --wait-timeout duration Timeout for wait (default 15m0s) |
There was a problem hiding this comment.
--wait-timeout duration Maximum time to download the required images and set up pupernetes
docs/pupernetes_reset.md
Outdated
| -h, --help help for reset | ||
| --api-address string Address for the pupernetes API ip:port (default "127.0.0.1:8989") | ||
| -a, --apply Apply manifests-api after reset, useful when resetting kube-system namespace | ||
| --client-timeout duration timeout for reset (default 1m0s) |
There was a problem hiding this comment.
--client-timeout duration Maximum time waited for a pupernetes command to be executed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Multiple timeouts referenced a single viper entry.
This discard any user input value.
I added a customisable timeout for the reset command.
I removed few viper calls from the run package see #40