-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix locale and string encoding #1
Conversation
Would it be helpful to add a check that the needed locale actually got generated, i.e.
? |
@p-datadog I was thinking about that as well, if only to be able to check that this PR works as expected across the board by having it checking itself instead of going through this PR's generated images manually. Let me create a quick and stupid test harness for that. |
I've added a couple test cases and a test harness, failure on some older rubies is expected at this stage because of the EDIT: HA! It actually worked. |
e5a97fe
to
2de9e4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Pushing images with https://github.com/DataDog/images-rb/actions/runs/9783505263 |
Why
Discovered that the string encoding is
US-ASCII
Locale was not set correctly:
How
Before in the build process:
How success looks like after the change
Note
locale-gen
generate localisation files from templates (/etc/locales.gen
).