Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Add "How does Datadog help you?" to feature request template #4267

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Jan 8, 2025

What does this PR do?

This PR adds a "How does Datadog help you?" question to the feature request template.

Motivation:

We've had it in the past, but it got removed as part of some cleanups in #4235, but we'd like to keep it for the reasons discussed in https://github.com/datadog/dd-trace-rb/pull/4235/files#r1891447495 .

Change log entry

None

Additional Notes:

N/A

How to test the change?

I'm not actually sure if there's any way to preview this before it's merged. But, you can check that

  1. It's copy-pasted from https://github.com/DataDog/dd-trace-rb/blob/e3ea38f741bf936fda5b9e41c1271c38e6c61e8a/.github/ISSUE_TEMPLATE/bug_report.yaml
  2. How that one looks in https://github.com/DataDog/dd-trace-rb/issues/new?template=bug_report.yaml

**What does this PR do?**

This PR adds a "How does Datadog help you?" question to the
feature request template.

**Motivation:**

We've had it in the past, but it got removed as part of some cleanups
in #4235, but we'd like to keep it for the reasons discussed in
https://github.com/datadog/dd-trace-rb/pull/4235/files#r1891447495 .

**Additional Notes:**

N/A

**How to test the change?**

I'm not actually sure if there's any way to preview this before
it's merged. But, you can check that

1. It's copy-pasted from
   https://github.com/DataDog/dd-trace-rb/blob/e3ea38f741bf936fda5b9e41c1271c38e6c61e8a/.github/ISSUE_TEMPLATE/bug_report.yaml
2. How that one looks in
   https://github.com/DataDog/dd-trace-rb/issues/new?template=bug_report.yaml
@ivoanjo ivoanjo requested a review from a team as a code owner January 8, 2025 17:31
@ivoanjo ivoanjo requested a review from tlhunter January 8, 2025 17:31
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jan 8, 2025
@ivoanjo ivoanjo added dev/internal Other internal work that does not need to be included in the changelog and removed dev/internal Other internal work that does not need to be included in the changelog labels Jan 8, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 8, 2025

Datadog Report

Branch report: ivoanjo/add-help-you-question-to-feature-request
Commit report: 67aba58
Test service: dd-trace-rb

✅ 0 Failed, 22118 Passed, 1477 Skipped, 5m 49.86s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 8, 2025

Benchmarks

Benchmark execution time: 2025-01-08 17:54:46

Comparing candidate commit 67aba58 in PR branch ivoanjo/add-help-you-question-to-feature-request with baseline commit e3ea38f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ivoanjo ivoanjo merged commit 91d001c into master Jan 9, 2025
342 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/add-help-you-question-to-feature-request branch January 9, 2025 09:10
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants