Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for 3.4 support #4249

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Jan 2, 2025

What does this PR do?
Add Ruby 3.4 to the list of compatibilities and update the DevelopmentGuide doc.

Motivation:
Keep our public docs updated to reflect new support.

Change log entry
Yes. Support for Ruby 3.4 is added.

Additional Notes:
N/A

How to test the change?
N/A

@sarahchen6 sarahchen6 requested review from a team as code owners January 2, 2025 15:45
Copy link

github-actions bot commented Jan 2, 2025

Thank you for updating Change log entry section 👏

Visited at: 2025-01-02 15:45:56 UTC

@github-actions github-actions bot added the docs Involves documentation label Jan 2, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 2, 2025

Datadog Report

Branch report: sarahchen6/update-compatibility-for-3.4
Commit report: e4c0271
Test service: dd-trace-rb

✅ 0 Failed, 22123 Passed, 1475 Skipped, 4m 59.89s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 2, 2025

Benchmarks

Benchmark execution time: 2025-01-03 09:40:45

Comparing candidate commit e4c0271 in PR branch sarahchen6/update-compatibility-for-3.4 with baseline commit e8a6307 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch on the docs :)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (e8a6307) to head (e4c0271).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4249      +/-   ##
==========================================
- Coverage   97.74%   97.74%   -0.01%     
==========================================
  Files        1355     1355              
  Lines       82366    82365       -1     
  Branches     4230     4230              
==========================================
- Hits        80512    80507       -5     
- Misses       1854     1858       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivoanjo ivoanjo added this to the 2.9.0 milestone Jan 3, 2025
@sarahchen6 sarahchen6 merged commit 3ea16f1 into master Jan 3, 2025
337 checks passed
@sarahchen6 sarahchen6 deleted the sarahchen6/update-compatibility-for-3.4 branch January 3, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants