Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase benchmark validation timeout #4225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase benchmark validation timeout #4225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/datadog/tracing/validate_benchmarks_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
benchmarks_to_validate.each do |benchmark|
describe benchmark do
it 'runs without raising errors' do
expect_in_fork do
expect_in_fork(timeout_seconds: 30) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered a timeout failure in #4207 but I thought my benchmark was taking too long (which still may be the case).

My understanding is the current timeout is 10 seconds, perhaps raising it to 20 would be sufficient rather than going to 30? What do you think?

load "./benchmarks/#{benchmark}.rb"
end
end
Expand Down
Loading