Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely merge options #4214

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Safely merge options #4214

wants to merge 1 commit into from

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 9, 2024

What does this PR do?
Provides a way for configuration overrides to be reliably merged and validated.

Change log entry

Additional Notes:

How to test the change?

@github-actions github-actions bot added core Involves Datadog core libraries integrations Involves tracing integrations tracing labels Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

👋 Hey @marcotc, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2024-12-09 23:47:53 UTC

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2024

Benchmarks

Benchmark execution time: 2024-12-10 00:10:09

Comparing candidate commit 4d554d5 in PR branch merge-options-safe with baseline commit dc55301 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.693op/s; -0.683op/s] or [-10.519%; -10.358%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant